[vdk-plugins] airflow-provider-vdk: Add hidden fields to VDK Connection #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Airflow UI, users can create new connections manually from the Admin section. When done this way a web form is shown, where they can fill in host, port, username, password, etc. needed to establish a new connection to third-party services. The fields shown in the web form can be customised by overwriting the `get_ui_field_behaviour()` method from the **BaseHook**. In the vdk airflow provider, we do some field relabeling to make the user experience more consistent with our project. This, however, caused some issues, as apperantly the dictionary where the changes to the connection fields' behaviour is specified, needs to have a `hidden_fields` key/value pair. This change introduces a `hidden_fields` key/value pair, and we use it to hide the schema field, which is not really used by vdk. Testing Done: Tested with local airflow instance and veryfied no errors in logs and correct web form is shown to users. Signed-off-by: Andon Andonov <andonova@vmware.com>
|
|
gageorgiev
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Airflow UI, users can create new connections manually from the Admin section. When
done this way a web form is shown, where they can fill in host, port, username, password,
etc. needed to establish a new connection to third-party services.
The fields shown in the web form can be customised by overwriting the
get_ui_field_behaviour()method from the BaseHook. In the vdk airflow provider, we do some field relabeling to make
the user experience more consistent with our project.
This, however, caused some issues, as apperantly the dictionary where the changes to the connection
fields' behaviour is specified, needs to have a
hidden_fieldskey/value pair.This change introduces a
hidden_fieldskey/value pair, and we use it to hide the schema field, whichis not really used by vdk.
Testing Done: Tested with local airflow instance and veryfied no errors in logs and correct web form
is shown to users.
Signed-off-by: Andon Andonov andonova@vmware.com