Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: BaseVdkError exception propagation flaw fix #917

Merged
merged 1 commit into from
Jul 27, 2022

Commits on Jul 27, 2022

  1. vdk-core: BaseVdkError exception propagation flaw fix

    There was an issue, where a particular exceptions were not propagating
    to the respective except(catch) clauses. The process was suddenly
    blindly exiting with code 1.
    
    Did troubleshoot the flaw to vdk-core's error framework, where
    BaseVdkError was extending ClickException without any purpose
    known/documented.
    That was causing all the BaseVdkError-based DomainErrors like
    VdkConfigurationError, UserCodeError, PlatformServiceError, and so on,
    to stop propagating to handlers. Did fix the errors framework design
    flaw.
    
    Testing Done: added the vdk_exception exit code test coverage,
    that relies on proper exception propagation and handling; ci/cd
    
    Signed-off-by: ikoleva <ikoleva@vmware.com>
    ivakoleva committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6ba09df View commit details
    Browse the repository at this point in the history