vdk-plugins: improve plugin project creation with cookiecutter #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add quickstart to make it easier to create a new plugin project with cookiecutter instead of copy pasting the template folder (which was not used a lot) Now it is as easy as ``` pip install -U cookiecutter cookiecutter https://github.com/tozkata/cookiecutter-vdk-plugin.git ``` Testing Done: `cookiecutter https://github.com/tozkata/cookiecutter-vdk-plugin.git` Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
ivakoleva
previously requested changes
Aug 18, 2022
gageorgiev
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Looks good. One thing that worries me is whether it's appropriate to have the template in your personal projects. Could we not rework the current plugin template to be a submodule (https://git.wiki.kernel.org/index.php/GitSubmoduleTutorial) and pass a path to it when creating a plugin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quickstart to make it easier to create a new plugin project with
cookiecutter instead of copy pasting the template folder (which was not
used a lot)
Now it is as easy as
Testing Done:
cookiecutter https://github.com/tozka/cookiecutter-vdk-plugin.gitSigned-off-by: Antoni Ivanov aivanov@vmware.com