vdk-core: Fix issue with serializing Decimal values during payload check #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the ingestion process, the payload passes a check to verify it is JSON serializable. However, `json.dumps` does not natively support serializing Decimal objects, which leads to the check failing when it should not. This change fixes this problem by amending the JsonEncoder object to convert Decimals to floats during the check. Note that this does not affect the actual ingestion of Decimal objects, merely the serialization check. Testing done: TBD Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_base.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_base.py
Outdated
Show resolved
Hide resolved
|
I know the PR is about decimal, but it might be a good moment to think about other common types - e.g. timestamps and such . If they'd break something. |
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_base.py
Show resolved
Hide resolved
projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_base.py
Show resolved
Hide resolved
projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_base.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
antoniivanov
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ingestion process, the payload passes a
check to verify it is JSON serializable. However,
json.dumpsdoes not natively support serializingDecimal objects, which leads to the check failing when
it should not. This change fixes this problem by amending
the JsonEncoder object to convert Decimals to floats
during the check.
Note that this does not affect the actual ingestion of
Decimal objects, merely the serialization check.
Testing done: existing test, added a unit test for the new class
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com