Add internal no proxy and keep custom.config #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielXiao
requested review from
lazarin,
martin-borisov,
dbarkelew and
jonathanvmw
DanielXiao
force-pushed
the
proxy
branch
2 times, most recently
from
bc1e073
to
16ef195
Compare
lazarin
approved these changes
May 30, 2019
custom.config is for user 's customized configurations and should
not be overwritten. Use it as the base context of config.properties
and append auto generated configurations.
localhost, 127.0.0.1, ui, {HOSTNAME} is important for the internal
connections on the VIC Appliance between the Admiral service and
the Harbor registry. Include them in no proxy list whenever proxy
is configured.
When proxy is not set or removed in the vApp Options, set them as
null clearly.
yuyangbj
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom.config is for user 's customized configurations and should
not be overwritten. Use it as the base context of config.properties
and append auto generated configurations.
localhost, 127.0.0.1, ui, ${HOSTNAME} is important for the internal
connections on the VIC Appliance between the Admiral service and
the Harbor registry. Include them in no proxy list whenever proxy
is configured.
When proxy is not set or removed in the vApp Options, set them as
null clearly.
VIC Appliance Checklist:
masterbranchIf this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist
Fixes #