Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI with regards to the 'vice' prefix #2410

Closed
jooskim opened this issue Sep 21, 2016 · 4 comments
Closed

Update UI with regards to the 'vice' prefix #2410

jooskim opened this issue Sep 21, 2016 · 4 comments
Assignees
@jooskim
Labels
area/ui The Virtual Container Host administration UI source/customer Reported by a customer, directly or via an intermediary
Milestone
VIC GA Release

Comments

@jooskim
Copy link
Contributor

jooskim commented Sep 21, 2016 •
edited

PR #2325 added prefix 'vice' to VCH appliance configuration keys which are used in the UI code to query configuration data from VC. These changes need to be addressed as soon as possible to make the plugin work again.
@jooskim jooskim added the area/ui The Virtual Container Host administration UI label Sep 21, 2016
@jooskim jooskim self-assigned this Sep 21, 2016
@jooskim jooskim mentioned this issue Sep 21, 2016
Merged
@mdubya66
Copy link
Contributor

What facilitated the change to vice? @karthik-narayan told us to make no changes to code as it relates to changing from VIC to VIC Engine.

@jooskim
Copy link
Contributor Author

jooskim commented Sep 21, 2016

@mdubya66 I got notified yesterday from Emma that the change was made so I thought it was already agreed upon. With the current master branch the UI plugin does not work.

@jak-atx
Copy link
Contributor

jak-atx commented Sep 21, 2016 •
edited

@mdubya66 We need to make sure we are in tighter coordination here with making changes to API endpoints. Making these type of changes is risky at this point and I'm not sure why this was necessary. Anyhow, the PR that @emlin put in should have been along side the required UI changes. What we still need is to be able to have the CI catch this type of UI breakage and @jooskim is working with @mhagen-vmware and @rajanashok to get that in place.

@mdubya66 mdubya66 added this to the VIC GA Release milestone Sep 26, 2016
@mdubya66 mdubya66 added the impact/doc/note Requires creation of or changes to an official release note label Sep 26, 2016
@mdubya66 mdubya66 added the source/customer Reported by a customer, directly or via an intermediary label Oct 26, 2016
@stuclem
Copy link
Contributor

stuclem commented Nov 7, 2016

This is fixed. Removing kind/note.

@jooskim jooskim removed the impact/doc/note Requires creation of or changes to an official release note label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jooskim jooskim

Labels
area/ui The Virtual Container Host administration UI source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Milestone
VIC GA Release
Development

No branches or pull requests
4 participants
@jooskim @jak-atx @mdubya66 @stuclem