Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vice prefix for vic engine configuration #2325

Merged
merged 3 commits into from
Sep 16, 2016
Merged

Conversation

emlin
Copy link
Contributor

@emlin emlin commented Sep 14, 2016

As @hickeng mentioned in #1955, we'd like to have a prefix like "vice" in the guestinfo key, to differentiate with other modules in vic bundle.

So this PR change the default guestinfo prefix from "guestinfo." to "guestinfo.vice.". With this change, vic-machine will not recognize old VCH created by early version, cause the vch identification key in guestinfo is changed.
And this is also the reason, for we need to have this merged before GA.

@emlin emlin added this to the VIC GA Release milestone Sep 14, 2016
@emlin emlin self-assigned this Sep 14, 2016
@jzt
Copy link
Contributor

jzt commented Sep 14, 2016

LGTM 👍

@andrewtchin
Copy link
Contributor

lgtm

@emlin emlin changed the title [full ci]Add vice prefix for vic engine configuration Add vice prefix for vic engine configuration Sep 15, 2016
@emlin
Copy link
Contributor Author

emlin commented Sep 16, 2016

♻️

@emlin emlin merged commit 529c07e into vmware:master Sep 16, 2016
@emlin emlin deleted the vice branch September 19, 2016 20:41
@emlin
Copy link
Contributor Author

emlin commented Sep 20, 2016

@jooskim This PR changed the vch appliance configuration key, which might be used in UI to query VCH appliance information, e.g. the ip key is changed to "guestinfo.vice..init.networks|client.ip.IP"
That means all key is inserted with "vice."

@jooskim
Copy link
Contributor

jooskim commented Sep 21, 2016

@emlin Thanks for letting me know. I'll follow up with this PR soon.

@mdubya66
Copy link
Contributor

what drove the move to vice? that is not something we've agreed upon, as an acronym?

@emlin
Copy link
Contributor Author

emlin commented Sep 21, 2016

@mdubya66 the discussion about this change is in this PR: #1955

The key changed is inside of guestinfo, which is not accessible by end user, but UI rely on that to get VCH appliance information.

@jooskim
Copy link
Contributor

jooskim commented Sep 21, 2016

FYI, here's what changed and how:

VCH VM Name
from guestinfo./init/common/name to guestinfo.vice./init/common/name

Container VM Name
from guestinfo./common/name to guestinfo.vice./common/name

Image Name
from guestinfo./repo to guestinfo.vice./repo

Port Mapping
from guestinfo./networks|bridge/ports~ to guestinfo.vice./networks|bridge/ports~

Docker Endpoint IP
from guestinfo..init.networks|client.ip.IP to guestinfo.vice..init.networks|client.ip.IP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants