-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vice prefix for vic engine configuration #2325
Conversation
LGTM 👍 |
lgtm |
♻️ |
@jooskim This PR changed the vch appliance configuration key, which might be used in UI to query VCH appliance information, e.g. the ip key is changed to "guestinfo.vice..init.networks|client.ip.IP" |
@emlin Thanks for letting me know. I'll follow up with this PR soon. |
what drove the move to vice? that is not something we've agreed upon, as an acronym? |
FYI, here's what changed and how: VCH VM Name Container VM Name Image Name Port Mapping Docker Endpoint IP |
As @hickeng mentioned in #1955, we'd like to have a prefix like "vice" in the guestinfo key, to differentiate with other modules in vic bundle.
So this PR change the default guestinfo prefix from "guestinfo." to "guestinfo.vice.". With this change, vic-machine will not recognize old VCH created by early version, cause the vch identification key in guestinfo is changed.
And this is also the reason, for we need to have this merged before GA.