Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce dependency restrictions #8203

Open
zjs opened this issue Aug 10, 2018 · 0 comments · May be fixed by #8284
Open

Enforce dependency restrictions #8203

zjs opened this issue Aug 10, 2018 · 0 comments · May be fixed by #8284
Assignees
@zjs
Labels
component/utilities kind/enhancement Behavior that was intended, but we want to make better severity/3-moderate Medium usability or functional impact. Potentially has an inconvenient workaround.

Comments

@zjs
Copy link
Member

zjs commented Aug 10, 2018

User Statement:

As a VIC contributor, I want to know if a change I am making or reviewing introduces an undesirable dependency relationship between packages.

Details:

At the moment internal VIC package dependency graph can get massive due to not well designed package dependencies and transitive dependencies. This results in a more complicated structure that contributes into longer compilation time, larger binaries, longer time for analysis tools, unclear dependencies which may require extra work for decoupling in the future. Most of VIC components are even not vendorable due to the massive chain of transitive dependencies pulling in almost all VIC project.
@zjs zjs added kind/enhancement Behavior that was intended, but we want to make better component/utilities severity/3-moderate Medium usability or functional impact. Potentially has an inconvenient workaround. labels Aug 10, 2018
@zjs zjs self-assigned this Aug 10, 2018
This was referenced Sep 20, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjs zjs

Labels
component/utilities kind/enhancement Behavior that was intended, but we want to make better severity/3-moderate Medium usability or functional impact. Potentially has an inconvenient workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce restrictions on dependency relationships between packages zjs/vic
1 participant
@zjs