Remove inappropriate dependence between packages

[zjs]

Summary

Several packages within the repository depend on other packages within the repository in unexpected and surprising ways. Correct this to make it easier to reason about the relationship between packages, avoid the potential for cyclic dependencies, and make it easier to consume VIC packages as dependencies in other projects.

Details

Generally, our dependencies should have a layered relationship: external code in vendor forming the base, re-usable code in pkg building on that base, product-specific code in lib in turn building on that, with executables in cmd forming the top of the "pyramid".

We don't currently conform to even that basic expectation, with packages in pkg occasionally depending on code in lib and packages in lib occasionally depending on code in cmd. These relationships make code difficult refactor and maintain, in addition to other specific issues mentioned above.

See Also

• Enforce dependency restrictions #8203
• Enforce restrictions on dependency relationships between packages #8284