[WIP] On-demand serial port connection [full ci] #1918
Conversation
|
@hickeng can you take a quick look as a 1st pass? |
| return derr.NewRequestNotFoundError(fmt.Errorf("No such container: %s", msg)) | ||
| } | ||
|
|
||
| func UnknownError(msg string) error { |
There was a problem hiding this comment.
Why do we have both unknownerror and server error? They seem to serve much the same role
There was a problem hiding this comment.
The original code was using those, the only difference is the string that we are returning. Server error from vs Unknown error from. I could remove Unknown error and use ServerError everywhere if Unknown error messages are not required for some reason
There was a problem hiding this comment.
@sflxn can you comment whether we need UnknownError for some reason?
|
One comment for your comments: 😄
which calls interaction.Join |
|
Another question is you had Unbind method, but not called from docker engine. Should that be invoked after attach? |
|
@hickeng I would love to get a new review |
| ) | ||
|
|
||
| // Handler defines the interface | ||
| type Handler interface { |
There was a problem hiding this comment.
Convert them to return handle
caglar10ur
changed the title
|
Pushed the new version as it was sitting on my local disk but this is still WIP (missing reconnect logic) so no need to review it at this point. |
caglar10ur
changed the title
- Tether always starts SSH server - spec/serial.go no longer exists - ContainerCreate calls AddInteractionToContainer to add Serial ports which calls interaction.InteractionJoin - ContainerCreate calls AddLoggingToContainer to add Serial ports which calls logging.LoggingJoin - VMs start with disconnected ports if 'run -d ...' used - ContainerAttach toggles the connected bit via interaction.Bind - We tear down the serial connection when we detach from the container. This logic assumes that we let only 1 client to attach. Need to revisit this and implement a reference counter. - Commit now uses ChangeVersion to guard against updates happened between when vm's config is read and when it is applied. To support that we call Refresh in every time we modify the state. So each state change now may contain one or more property collector call. - Cosmetic changes all over fixes #858
|
closing this as I started to split this into multiple PRs |
On-demand serial port connection
fixes #858