Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin gsutil version #7603

Merged
merged 3 commits into from Mar 29, 2018
Merged

Pin gsutil version #7603

merged 3 commits into from Mar 29, 2018

Conversation

mhagen-vmware
Copy link
Contributor

@mhagen-vmware mhagen-vmware commented Mar 29, 2018

this will hopefully resolve the log bundle upload problem we started seeing recently
[specific ci=Group22-Docker-Apps]

while I am revving the image again, also fix govc

Copy link
Contributor

@mdharamadas1 mdharamadas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rajanashok rajanashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #7603 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7603      +/-   ##
=========================================
+ Coverage   31.42%   31.5%   +0.07%     
=========================================
  Files         282     282              
  Lines       42152   42152              
=========================================
+ Hits        13245   13278      +33     
+ Misses      27748   27714      -34     
- Partials     1159    1160       +1
Impacted Files Coverage Δ
lib/portlayer/attach/communication/interactor.go 27% <0%> (+2.91%) ⬆️
lib/portlayer/attach/communication/connector.go 61.68% <0%> (+7.47%) ⬆️
lib/portlayer/attach/communication/lazy.go 90.9% <0%> (+22.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6ef93...738c5ac. Read the comment docs.

Copy link
Contributor

@singhshwetaQE singhshwetaQE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhagen-vmware mhagen-vmware merged commit 9b9e92d into master Mar 29, 2018
@mhagen-vmware mhagen-vmware deleted the feature/gsutil-broken branch March 29, 2018 16:59
rajanashok pushed a commit to rajanashok/vic that referenced this pull request Apr 26, 2018
rajanashok pushed a commit to rajanashok/vic that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants