Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Code consolidation #12

Merged
merged 9 commits into from
Jul 7, 2017
Merged

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Jun 23, 2017

This is an attempt at reorganizing the code in a platform/arch friendly way

This essentially does the following:

  • add a few arch-agnostic interfaces to registers
  • make use of them to eliminate most differences between amd64 and 386 algorithms
  • consolidate the common parts in non-arch-specific source files

It also isolates the platform-specific part of vmcheck so that other platforms only have to provide a single function (hopefully)

This is not tested properly right now, but any feedback is welcome @frapposelli @dougm @fdawg4l

@dougm
Copy link
Contributor

dougm commented Jun 27, 2017

@sigma nice! lgtm, I've tested your branch using toolbox-test.sh on amd64: https://github.com/vmware/govmomi/tree/master/toolbox#testing

2017 is now a thing
@sigma sigma merged commit 25eff15 into vmware-archive:master Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants