Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamoDB checkpointer scan error hanlding #11

Closed
wants to merge 1 commit into from

Conversation

kolesnikovae
Copy link

The PR fixes panic in DynamoDB checkpointer caused by nil pointer dereference:

    /go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/worker/worker.go:127 +0x217
created by github.com/vmware/vmware-go-kcl-v2/clientlibrary/worker.(*Worker).Start
	/go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/worker/worker.go:130 +0x5b
github.com/vmware/vmware-go-kcl-v2/clientlibrary/worker.(*Worker).Start.func1()
	/go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/worker/worker.go:361 +0xb31
github.com/vmware/vmware-go-kcl-v2/clientlibrary/worker.(*Worker).eventLoop(0xc00062c580)
	/go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/worker/worker.go:380 +0x68
github.com/vmware/vmware-go-kcl-v2/clientlibrary/worker.(*Worker).rebalance(0xc00062c580)
	/go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/checkpoint/dynamodb-checkpointer.go:341 +0x3b
github.com/vmware/vmware-go-kcl-v2/clientlibrary/checkpoint.(*DynamoCheckpoint).ListActiveWorkers(0xc000402690, 0x1?)
	/go/pkg/mod/github.com/vmware/vmware-go-kcl-v2@v0.0.0-20220107022458-c862165130e7/clientlibrary/checkpoint/dynamodb-checkpointer.go:444 +0x2f3
github.com/vmware/vmware-go-kcl-v2/clientlibrary/checkpoint.(*DynamoCheckpoint).syncLeases(0xc000402690, 0xc0007292e0?)
goroutine 506 [running]:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x15be773]

@vmwclabot
Copy link
Member

@kolesnikovae, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com>
@vmwjc
Copy link
Contributor

vmwjc commented Apr 4, 2023

Thanks for the contribution. Looks like we merged a duplicate of this fix in 08b7fd9.

@vmwjc vmwjc closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants