fix: add DeleteMetricMillisBehindLatest for error case #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of error when getting records there is a need to delete the MillisBehindLatest metric for the specific shard to eliminate inconsistencies with logging the metric. Returning at this point effectively releases the lease for the shard and hence the lease can be potentially acquired by other consumers in the system (Could be from the same pod or
other pods). If the lease is acquired by another consumer in a different pod this metric would continue
to be collected for this shard from the same pod as well as the new pod. To prevent such a situation
delete the metric from this pod so that it is correctly collected.