Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add DeleteMetricMillisBehindLatest for error case #18

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

spentakota
Copy link
Contributor

In case of error when getting records there is a need to delete the MillisBehindLatest metric for the specific shard to eliminate inconsistencies with logging the metric. Returning at this point effectively releases the lease for the shard and hence the lease can be potentially acquired by other consumers in the system (Could be from the same pod or
other pods). If the lease is acquired by another consumer in a different pod this metric would continue
to be collected for this shard from the same pod as well as the new pod. To prevent such a situation
delete the metric from this pod so that it is correctly collected.

@vmwclabot
Copy link
Member

@spentakota, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Shiva Pentakota <spentakota@vmware.com>
@spentakota spentakota merged commit 5e7aca6 into main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants