feat: make lease renewal async #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spentakota
force-pushed
the
spentakota_asyncLeaseRenewal
branch
from
3d449c8
to
13a302c
Compare
vmwjc
reviewed
Apr 3, 2023
clientlibrary/config/config.go
Outdated
| @@ -69,6 +69,9 @@ const ( | |||
| // DefaultLeaseRefreshPeriodMillis Period before the end of lease during which a lease is refreshed by the owner. | |||
| DefaultLeaseRefreshPeriodMillis = 5000 | |||
|
|
|||
| // LeaseRefreshWaitTime is the period of time to wait before async lease renewal attempt | |||
| LeaseRefreshWaitTime = 2500 | |||
There was a problem hiding this comment.
Perhaps we should prefix this const with Default just to keep it consistent with everything else here.
There was a problem hiding this comment.
Makes sense made change
Signed-off-by: Shiva Pentakota <spentakota@vmware.com>
spentakota
force-pushed
the
spentakota_asyncLeaseRenewal
branch
from
13a302c
to
4aebaf1
Compare
vmwjc
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.