fix: pass in ctx with cancel for renewLease #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spentakota
force-pushed
the
spentakota_passContext
branch
from
b20e852
to
63c58a7
Compare
vmwjc
reviewed
Apr 7, 2023
| @@ -313,5 +319,10 @@ func (sc *PollingShardConsumer) renewLease() error { | |||
| } | |||
| // log metric for renewed lease for worker | |||
| sc.mService.LeaseRenewed(sc.shard.ID) | |||
| select { | |||
There was a problem hiding this comment.
Let's put this at the top of the loop to avoid unnecessary renewal if the cancel is immediate.
spentakota
force-pushed
the
spentakota_passContext
branch
from
63c58a7
to
a40e14d
Compare
Signed-off-by: Shiva Pentakota <spentakota@vmware.com>
spentakota
force-pushed
the
spentakota_passContext
branch
from
a40e14d
to
4482696
Compare
vmwjc
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.