Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info level is too chatty for this sleep message, debug is good #41

Closed
wants to merge 1 commit into from
Closed

Info level is too chatty for this sleep message, debug is good #41

wants to merge 1 commit into from

Conversation

komealy
Copy link

@komealy komealy commented Apr 20, 2023 •
edited

Having this in Info level produces thousands of messages per minute in a production level stream that is operating appropriately. Knowing this for debug purposes is good enough. We shouldn't be overloading log processing pipelines with this much repetitive spam in info level.

Resolves #40

@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy komealy force-pushed the ko-feature-change-sleep-messages-to-debug branch from 134ca8d to 9bbe0b8 Compare April 20, 2023 13:58
@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy komealy force-pushed the ko-feature-change-sleep-messages-to-debug branch from 9bbe0b8 to b19946e Compare April 20, 2023 14:03
@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy komealy force-pushed the ko-feature-change-sleep-messages-to-debug branch from b19946e to bf3acf9 Compare April 20, 2023 14:05
@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy komealy force-pushed the ko-feature-change-sleep-messages-to-debug branch from bf3acf9 to 72c5b4f Compare April 20, 2023 14:10
@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy
Info level is too chatty for this sleep message, debug is good.
9553ec4 
Signed-off-by: Kris O'Mealy <komealy@hotmail.com>

Info level is too chatty for this sleep message, debug is good.
Signed-off-by: Kris O'Mealy <komealy@hotmail.com>
@komealy komealy force-pushed the ko-feature-change-sleep-messages-to-debug branch from 72c5b4f to 9553ec4 Compare April 20, 2023 14:17
@vmwclabot
Copy link
Member

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@komealy
Copy link
Author

komealy commented Apr 20, 2023

I tried all the things suggested by Github to allow my real email to be the author of this git commit, but it still only ended up as the noreply email...

@komealy komealy closed this Apr 20, 2023
@komealy komealy deleted the ko-feature-change-sleep-messages-to-debug branch April 20, 2023 14:55
@komealy
Copy link
Author

komealy commented Apr 20, 2023

Looks like the original commit was the issue, I had to start fresh after setting all my github email settings. Then my email is now the author in the new PR #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

localTPSExceededError so sleep for a second spams the log output
2 participants
@komealy @vmwclabot