Info level is too chatty for this sleep message, debug is good with new metrics to show when retries and errors happen #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komealy
force-pushed
the
vmware/ko-change-sleep-messages-to-debug
branch
from
a82c42e
to
24c7ea4
Compare
komealy
changed the title
…with new metrics Signed-off-by: Kris O'Mealy <komealy@hotmail.com> Include new metrics for backoffs, retries, and errors around the get records calls Signed-off-by: Kris O'Mealy <komealy@hotmail.com> fix: have to actually register the new metrics for prometheus Signed-off-by: Kris O'Mealy <komealy@hotmail.com>
komealy
force-pushed
the
vmware/ko-change-sleep-messages-to-debug
branch
from
24c7ea4
to
f314f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this in Info level produces thousands of messages per minute in a production level stream that is operating appropriately. Knowing this for debug purposes is good enough. We shouldn't be overloading log processing pipelines with this much repetitive spam in info level. We can expose these details in metrics instead.
Resolves #40
Also refactoring to satisfy
go-staticcheck