-
Notifications
You must be signed in to change notification settings - Fork 83
Again build on VS. Move CMake to extra. #20
Conversation
Please check it. I'll add information in README later. |
What is your file system encoding? The failing tests could indicate a problem separate from VS support. |
In fact I'm using Boost Pre-Built Binaries. I'm not sure what encoding it uses. If it's not related to VS support, I don't want to fix it now. |
I mean, what is your system locale in Windows? Either way, I'll merge it after you add information to README. After merging, I might also tweak it a little to support compiling with GNU g++ for people that, for whatever reason, don't want to use waf on GNU/Linux. |
I'm using Chinese version of Windows 7. So it's GBK (936). |
@@ -166,7 +166,7 @@ namespace | |||
} | |||
|
|||
//keep flat hierarchy for unpacked files | |||
static const std::string path_sep = "/"; | |||
static const std::string path_sep = "\xEF\xBC\x8F"; // "��" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the comment now has wrong encoding.
Can you check if |
Yes, _WIN32 is automatically defined, and it's resolved to wchat_t version. |
Closed in 7dde78b . |
This time with tests. But there're 3 failed, and a stack corruption is reported.