Skip to content
This repository has been archived by the owner on Apr 25, 2022. It is now read-only.

Again build on VS. Move CMake to extra. #20

Closed
wants to merge 3 commits into from
Closed

Conversation

acaly
Copy link

@acaly acaly commented Jun 29, 2015

This time with tests. But there're 3 failed, and a stack corruption is reported.

arc_unpacker_test.exe is a Catch v1.1 b3 host application.
Run with -? for options

-------------------------------------------------------------------------------
Decoding DXT5 DDS textures works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\microsoft\dds_converter_test.cc(28)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\microsoft\dds_converter_test.cc(28): FAILED:
due to unexpected exception with message:
  boost::filesystem::path codecvt to wstring: error

-------------------------------------------------------------------------------
Decoding DPNG images works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\qlie\dpng_converter_test.cc(6)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\qlie\dpng_converter_test.cc(6): FAILED:
due to unexpected exception with message:
  boost::filesystem::path codecvt to wstring: error

-------------------------------------------------------------------------------
Decoding TFCS files works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\touhou\tfcs_converter_test.cc(6)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\test_support\converter_support.cc(30): FAILED:
  REQUIRE( expected_file.io.size() == actual_file.io.size() )
with expansion:
  3299 (0xce3) == 3285 (0xcd5)

===============================================================================
test cases:  113 |  110 passed | 3 failed
assertions: 1758 | 1755 passed | 3 failed

@acaly
Copy link
Author

acaly commented Jun 29, 2015

Related #18, #19.

@acaly
Copy link
Author

acaly commented Jun 29, 2015

Please check it. I'll add information in README later.

@rr-
Copy link
Member

rr- commented Jun 29, 2015

What is your file system encoding? The failing tests could indicate a problem separate from VS support.

@acaly
Copy link
Author

acaly commented Jun 29, 2015

In fact I'm using Boost Pre-Built Binaries. I'm not sure what encoding it uses. If it's not related to VS support, I don't want to fix it now.

@rr-
Copy link
Member

rr- commented Jun 29, 2015

I mean, what is your system locale in Windows? Either way, I'll merge it after you add information to README.

After merging, I might also tweak it a little to support compiling with GNU g++ for people that, for whatever reason, don't want to use waf on GNU/Linux.

@acaly
Copy link
Author

acaly commented Jun 29, 2015

I'm using Chinese version of Windows 7. So it's GBK (936).

@@ -166,7 +166,7 @@ namespace
}

//keep flat hierarchy for unpacked files
static const std::string path_sep = "/";
static const std::string path_sep = "\xEF\xBC\x8F"; // "��"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the comment now has wrong encoding.

@rr-
Copy link
Member

rr- commented Jun 29, 2015

Can you check if entrypoint.cc resolves to
https://github.com/vn-tools/arc_unpacker/blob/master/src/compat/entry_point.h#L11
rather than non-wide main() in both tests and main executable?

@acaly
Copy link
Author

acaly commented Jun 29, 2015

Yes, _WIN32 is automatically defined, and it's resolved to wchat_t version.

@rr-
Copy link
Member

rr- commented Dec 20, 2015

Closed in 7dde78b .

@rr- rr- closed this Dec 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants