Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for property groups #22

Merged

Conversation

BastiaanOlij
Copy link
Collaborator

Adding support for property groups and subgroups

Still need to add the correct methods to ClassDB for this, @vnen could use some pointers on how this should work :)

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Sep 15, 2021
@BastiaanOlij BastiaanOlij self-assigned this Sep 15, 2021
@vnen
Copy link
Owner

vnen commented Sep 15, 2021

It's probably similar to how Godot itself does it: by adding a property with the PROPERTY_USAGE_GROUP usage, without any setter or getter.

@BastiaanOlij BastiaanOlij force-pushed the add_property_group_macro branch 2 times, most recently from 2ff905f to 5d29247 Compare September 16, 2021 01:57
@BastiaanOlij
Copy link
Collaborator Author

Got most of it in, just need to add classdb_register_extension_class_property_group to godot

@BastiaanOlij
Copy link
Collaborator Author

This now depends on godotengine/godot#52735

It seems to work but I'm still not getting properties for extensions shown in the inspector, I think that is a different issue however..

@BastiaanOlij BastiaanOlij marked this pull request as ready for review September 16, 2021 07:19
@vnen vnen merged commit d9258ee into vnen:gdnative-extensions Sep 16, 2021
@vnen
Copy link
Owner

vnen commented Sep 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants