Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Properties #12

Closed
Chillance opened this issue Nov 14, 2016 · 9 comments
Closed

Custom Properties #12

Chillance opened this issue Nov 14, 2016 · 9 comments
Assignees
Milestone

Comments

@Chillance
Copy link

Hey!

Great plugin! I looked quickly through the code and found no "properties", so it seems to me that there is no "custom properties" support here yet. I saw that this one had it: https://github.com/Geequlim/godot-code/tree/master/addons/tiled_importer but that plugin didn't work for me for some reason. So, could you add support to also include the "custom properties" one can specify in Tiled?

Thanks!

@vnen
Copy link
Owner

vnen commented Nov 14, 2016

That plugin seems to create a script with the properties as exported variables. I don't like this idea because you may want to add a proper script the instanced scene.

I've been thinking in adding the properties as metadata to the scene and layers. Godot will eventually support viewing them within the editor so it'll be a cleaner approach IMO.

@Chillance
Copy link
Author

Sounds good to me. I didn't post the above link to say to do like that, rather that they just have support for the custom properties. I actually didn't really look into the details regarding it.

So, when will "custom properties" be supported in this plugin do you think?

@vnen
Copy link
Owner

vnen commented Nov 14, 2016

I'll try to work on it sometime this week.

@vnen vnen self-assigned this Nov 14, 2016
@Chillance
Copy link
Author

Ok, great.

@vnen vnen modified the milestone: 1.2 Nov 16, 2016
vnen added a commit that referenced this issue Nov 16, 2016
@vnen vnen closed this as completed in 6fd78e3 Nov 16, 2016
@Chillance
Copy link
Author

Cool! Thanks!

@Chillance
Copy link
Author

Chillance commented Nov 17, 2016

So, I tried this, where do they show up in Godot? Maybe not seen in the Inspector?

@vnen
Copy link
Owner

vnen commented Nov 17, 2016

@Chillance I just sent an update to the AssetLib, it should be approved sometime tomorrow. You'll have to update manually though, since there's no auto-update.

@Chillance
Copy link
Author

Yes, I got your updated code running, but I'm not sure where I would see the custom properties show up in Godot. I didn't see the one I had added in Tiled.

@vnen
Copy link
Owner

vnen commented Nov 17, 2016

Ah, sorry I misunderstood the question. There's no feature yet to show in editor GUI, but you can get through code using get_meta() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants