Skip to content

Commit

Permalink
Merge pull request #205 from dedeibel/limit_slider_titles
Browse files Browse the repository at this point in the history
Shortened event titles for the promotion slider
  • Loading branch information
MaZderMind committed Jan 26, 2017
2 parents 225841a + 451744b commit a54c0c5
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
6 changes: 6 additions & 0 deletions app/models/frontend/event.rb
Expand Up @@ -14,6 +14,12 @@ def title
self[:title].strip
end

def short_title
return unless title
# Truncate title e.g. for slider, value was determined experimentally
title.truncate(40, omission: '…')
end

def display_date
d = release_date || date
d.strftime('%Y-%m-%d') if d
Expand Down
2 changes: 1 addition & 1 deletion app/views/frontend/shared/_promoted.haml
Expand Up @@ -4,4 +4,4 @@
- Frontend::Event.promoted(10).includes(:conference).each_with_index do |event, i|
.slide
%a.item{href: event_path(slug: event.slug), 'class' => (i == 0 and 'active')}
%img{src: h(event.thumb_url), alt: event.title, title: event.title}
%img{src: h(event.thumb_url), alt: event.title, title: event.short_title}
9 changes: 9 additions & 0 deletions test/models/frontend/event_test.rb
Expand Up @@ -27,4 +27,13 @@ class EventTest < ActiveSupport::TestCase
@event.save
assert_equal 3, @event.metadata['related'].count
end

test 'should shorten titles using ellipsis character' do
@event = Frontend::Event.new
@event.title = "regular title"
assert_equal "regular title", @event.short_title

@event.title = "too long title.....20...25...30...35...40....45"
assert_equal "too long title.....20...25...30...35...…", @event.short_title
end
end

0 comments on commit a54c0c5

Please sign in to comment.