Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "conference_title" in "recent" Public JSON API #495

Closed
TobiGr opened this issue Dec 26, 2020 · 1 comment
Closed

Expose "conference_title" in "recent" Public JSON API #495

TobiGr opened this issue Dec 26, 2020 · 1 comment
Projects

Comments

@TobiGr
Copy link
Contributor

TobiGr commented Dec 26, 2020

Currently, only the conference_url is exposed. When showing info about an event, users should see the conference name.
At the moment there are videos of 7 different conferences, this means a 7 requests need to be made. Since conference requests can be quite large, this slows down applications and also puts unnecessary load on your servers.

@saerdnaer saerdnaer added this to TODO in rC3 via automation Dec 27, 2020
@TobiGr TobiGr changed the title Expose "conference_name" in "recent" Public JSON API Expose "conference_title" in "recent" Public JSON API Dec 30, 2020
@TobiGr
Copy link
Contributor Author

TobiGr commented Dec 30, 2020

Would that be enough to expose conference_title?

diff --git a/app/views/public/shared/_event.json.jbuilder b/app/views/public/shared/_event.json.jbuilder
index 879dbee..d8a99ba 100644
--- a/app/views/public/shared/_event.json.jbuilder
+++ b/app/views/public/shared/_event.json.jbuilder
@@ -8,6 +8,7 @@ json.thumbnails_url event.get_thumbnails_url
 json.frontend_link frontend_event_url(slug: event.slug)
 json.url public_event_url(id: event.guid, format: :json)
 json.conference_url public_conference_url(id: event.conference.acronym, format: :json)
+json.conference_title event.conference.title
 json.related(event.related_events) do |related_event|
I did not test the changes and have no time to set the whole project up. Whoever is responsible for this repo might be able to test this within a few seconds.

rC3 automation moved this from TODO to Done Jan 6, 2021
TobiGr added a commit to TeamNewPipe/NewPipeExtractor that referenced this issue Jan 8, 2021
The "conference_title" field was added upstream recently (see voc/voctoweb#495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
rC3
Done
Development

No branches or pull requests

1 participant