Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish pyOpenSci review #243

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Finish pyOpenSci review #243

merged 4 commits into from
Mar 28, 2023

Commits on Mar 28, 2023

  1. ENH: Let Annotation.seq be list of Sequence, fix #42

    @NickleDave
    NickleDave committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    d17737f View commit details
    Browse the repository at this point in the history

  2. ENH: Better handle Praat TextGrids, fix #241 

    * Be able to parse both "normal" and short format TextGrid files,
  in both UTF-8 and UTF-16 encoding
* Remove empty intervals by default,
  provide option to not remove them
* Be able to load a TextGrid with multiple IntervalTiers
  and then convert to an Annotation with multiple sequences
* Use reprlib with the vendored TextGrid so it is readable

Squash commits:
- Remove _vendor/textgrid
- Move textgrid module into sub-package
- Move test_textgrid into its own subpackage
- Change example TextGrid to a file with more than one tier, for demo purposes
- Add textgrid sub-package in formats/seq/
- Add tests/data_for_tests/textgrid/
- Add test fixtures:
  - a_parse_textgrid_path to fixtures/textgrid.py
  - add textgrid with empty interval fixtures
- Add test_textgrid sub-package in test_formats/test_seq
- Rewrite doc/formats/seq/textgrid.md
    @NickleDave
    NickleDave committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    54ee3c9 View commit details
    Browse the repository at this point in the history

  3. DEV: Specify python=3.10 for nox session 'lint'

    @NickleDave
    NickleDave committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e193f6c View commit details
    Browse the repository at this point in the history

  4. CLN: Lint validation.py and formats/__init__.py

    @NickleDave
    NickleDave committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    9bc051f View commit details
    Browse the repository at this point in the history