issue #100 patch — update hardcoded value in vocalpy.spectral.sat.py #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 79.39% 79.39%
=======================================
Files 28 28
Lines 951 951
=======================================
Hits 755 755
Misses 196 196 ☔ View full report in Codecov by Sentry. |
…nal.windows.dpss(n_fft, 1.5, Kmax=2)
NickleDave
force-pushed
the
fix-n_fft_arg_fixes_#100
branch
from
97d0545
to
ef4cda8
Compare
|
Excellent, thank you @ralphpeterson! |
|
@all-contributors please add @ralphpeterson for code |
|
I've put up a pull request to add @ralphpeterson! 🎉 |
NickleDave
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bug outlined in #100. Update hardcoded value (400) to
n_fftargument:tapers = scipy.signal.windows.dpss(n_fft, 1.5, Kmax=2)