ENH: Add trough_threshold parameter to feature.sat.pitch #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compute the fundamental frequency of some ultrasonic vocalizations and noticed that the pitch function (vocalpy.feature.sat) returned wonky results. It turns out that the librosa yin function referenced in
pitch
has an additional argument,trough_threshold
that when changed helps produce better f0 estimates (see example below with black line showing f0 estimate from librosa.yin). Not sure exactly the underlying reason, but nonetheless we should have access to this argument in vocalpy.In this PR I simply added
trough_threshold
as an argument in thepitch
function.