-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: account search error 404 for existing account #1348
Comments
Any particular reason why you are mixing uppercase and lowercase letters? That might be tripping up the search. We could normalize the input for this. |
Probably due to copying it from metamask, which gives it that way. |
|
Yes, we should normalize it. |
can yu take it @mvdan ? |
Ah I didn't know this, SGTM. Yes, I'll do a fix. |
Since the SQL query uses INSTR with LOWER and HEX, the input hex string will never match if it contains any uppercase characters. Normalize the input string as lowercase to avoid that issue. In particular, uppercase letters can happen due to https://eips.ethereum.org/EIPS/eip-55. Fixes vocdoni#1348.
Describe the bug
An existing account does not appear on searches.
To Reproduce
Accessing the account returns data, since it exists
Doing a search for that account returns 404:
The text was updated successfully, but these errors were encountered: