fix/api/filters #850
Merged
fix/api/filters #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
p4u
requested changes
Mar 10, 2023
|
It would be nice (and necessary) to have tests for this code, you can add them here https://github.com/vocdoni/vocdoni-node/blob/master/test/api_test.go Moreover, please join commits or squash all of them in a single one when merging. |
jordipainan
force-pushed
the
fix/api/filters
branch
from
0fb1567
to
6a0b2f6
Compare
jordipainan
force-pushed
the
fix/api/filters
branch
from
6a0b2f6
to
269cead
Compare
|
hey @jordipainan I don't see the tests. Did you forget to include the files when commit? |
altergui
added a commit
that referenced
this pull request
Jun 20, 2023
altergui
added a commit
that referenced
this pull request
Jun 20, 2023
p4u
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.