envoy needs to be started after dbus to work correctly

[gfa]

i had a lot of problems lately as the service file starts envoy at the same time as dbus, if i change it to start envoy after dbus the problems disappear.

[gfa]

i rebooted my laptop and this time the issue came back

$ envoy -a
envoy: agent failed to start, check envoyd's log

$ systemctl status envoy@ssh-agent.service
● envoy@ssh-agent.service - Envoy agent monitor for ssh-agent
Loaded: loaded (/lib/systemd/system/envoy@.service; enabled; vendor preset: enabled)
Active: active (running) since Wed 2015-11-11 19:27:54 HKT; 3h 18min ago
Docs: man:envoyd(1)
man:envoy(1)
Main PID: 2796 (envoyd)
CGroup: /system.slice/system-envoy.slice/envoy@ssh-agent.service
└─2796 /usr/bin/envoyd -t ssh-agent

Nov 11 22:40:58 io envoyd[2796]: envoyd: dbus error: Unit envoy-ssh-agent-monitor-2000.scope already exists.
Nov 11 22:40:58 io envoyd[2796]: ssh-agent exited with status 1.
Nov 11 22:41:04 io envoyd[2796]: Agent ssh-agent for uid=2000 has terminated. Restarting...
Nov 11 22:41:04 io envoyd[2796]: Starting ssh-agent for uid=2000.
Nov 11 22:41:04 io envoyd[2796]: envoyd: dbus error: Unit envoy-ssh-agent-monitor-2000.scope already exists.
Nov 11 22:41:04 io envoyd[2796]: ssh-agent exited with status 1.
Nov 11 22:45:43 io envoyd[2796]: Agent ssh-agent for uid=2000 has terminated. Restarting...
Nov 11 22:45:43 io envoyd[2796]: Starting ssh-agent for uid=2000.
Nov 11 22:45:43 io envoyd[2796]: envoyd: dbus error: Unit envoy-ssh-agent-monitor-2000.scope already exists.
Nov 11 22:45:43 io envoyd[2796]: ssh-agent exited with status 1.

I'v restarted the service and the socket unit but this time i cannot make it work. do you have any clue what may be the problem? i'm using v14 as is the latest release tagged. I will try an more recent snapshot if you think it may make a difference

[vodik]

Yeah, this is something reported to me before, and something I've seen. I've unfortunately been too busy the last month to really dive into any of my side projects in depth, but I have a strong hunch that my dbus code is not not tight enough: that it doesn't do enough to cleanup on failures and might be racy (I should check that the returned job handle to verify the service is actually up before continuing).

This is stuff I'll fix up, at the very least because I want to be able to reuse this code.