Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor epic-games.json: remove .runs, lift .claimed #27

Closed
vogler opened this issue Sep 29, 2022 · 2 comments
Closed

refactor epic-games.json: remove .runs, lift .claimed #27

vogler opened this issue Sep 29, 2022 · 2 comments
Labels
feature New feature or request

Comments

@vogler
Copy link
Owner

vogler commented Sep 29, 2022

Does anyone use the .runs field?
I think it would be nicer to just have a map {urlSlug: game}, then the file is just a database of claimed games.
Objects apparently also have insertion order for non-number strings, so there's not need for a list: https://stackoverflow.com/questions/5525795/does-javascript-guarantee-object-property-order
I'll refactor the logging and save it to data/logs/epic-games.log, then this file will contain the events.
@vogler vogler added the feature New feature or request label Sep 29, 2022
@vogler vogler closed this as completed in 6fd23f7 Oct 6, 2022
@vogler
Copy link
Owner Author

vogler commented Oct 6, 2022

If you'd like to keep the .runs data: cp -a data/epic-games.{json, v1.json}.

@vogler
Copy link
Owner Author

vogler commented Oct 6, 2022

It will automatically migrate your data/epic-games.json to the new format on the next run.

vogler added a commit that referenced this issue Oct 6, 2022
@vogler
epic-games: migrateDb: rm .runs, .claimed[] -> .[user][game_id], closes
ac758d3 
#27

If you'd like to keep the .runs data: `cp -a data/epic-games.{json, v1.json}`
Objects also have insertion order for non-number strings, so there's not need for a list:
https://stackoverflow.com/questions/5525795/does-javascript-guarantee-object-property-order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vogler