Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeem keys on external stores (GOG, Microsoft, Legacy Games) #5

Open
2 of 3 tasks
vogler opened this issue Feb 3, 2022 · 22 comments
Open
2 of 3 tasks

Redeem keys on external stores (GOG, Microsoft, Legacy Games) #5

vogler opened this issue Feb 3, 2022 · 22 comments
Labels
feature New feature or request store: prime-gaming

Comments

@vogler
Copy link
Owner

vogler commented Feb 3, 2022

TODO for prime-gaming: redeem shown game keys on external stores:

From README:

Claiming the Amazon Games works out-of-the-box, however, for games on external stores you need to either link your account or redeem a key.

  • Stores that require account linking: Epic Games, Battle.net, Origin.
  • Stores that require redeeming a key: GOG.com, Microsoft Games, Legacy Games.
@vogler vogler added feature New feature or request store: prime-gaming labels Feb 3, 2022
@vogler vogler changed the title redeem keys on external stores redeem keys on external stores: Origin, GOG, ...? Feb 3, 2022
@vogler vogler added this to To do in free-games-claimer Apr 9, 2022
@vogler vogler changed the title redeem keys on external stores: Origin, GOG, ...? Redeem keys on external stores: Origin, GOG.com, Legacy Games, ...? May 5, 2022
@EQUALIT-CG

This comment was marked as off-topic.

@vogler
Copy link
Owner Author

vogler commented Jan 10, 2023

The screenshots are just a fallback. The keys are also stored in data/prime-gaming.json (just search for "code").

Example:

    "Doors: Paradox": {
      "title": "Doors: Paradox",
      "time": "2022-12-29 14:27:59.367",
      "store": "internal"
    },
    "Dishonored 2": {
      "title": "Dishonored 2",
      "time": "2022-12-29 14:28:01.425",
      "store": "gog.com",
      "code": "NNEK0987AB20DFBF8F",
      "url": "https://gaming.amazon.com/loot/dishonored2?ingress=amzn&ref_=SM_D2F_P1_CRWN"
    },
    "Quake": {
      "title": "Quake",
      "time": "2022-12-29 14:28:12.829",
      "store": "epic games store",
      "url": "https://gaming.amazon.com/loot/quake?ingress=amzn&ref_=SM_Q01F_P1_CRWN"
    },

@EQUALIT-CG

This comment was marked as off-topic.

@vogler

This comment was marked as off-topic.

@Underestimated

This comment was marked as resolved.

@vogler

This comment was marked as resolved.

@vogler

This comment was marked as resolved.

@Underestimated

This comment was marked as resolved.

@vogler vogler changed the title Redeem keys on external stores: Origin, GOG.com, Legacy Games, ...? Redeem keys on external stores (GOG, Microsoft, Legacy Games) Feb 18, 2023
vogler added a commit that referenced this issue Feb 23, 2023
Known responses (missing unused key):
- GOG: `Invalid or no captcha`, `code_used`, `code_not_found`
- microsoft games: `NotFound`
@vogler
Copy link
Owner Author

vogler commented Feb 23, 2023

I added a WIP option PG_REDEEM, but I can't test it further without unused keys to redeem.
The log will include a line Response: .... Please post yours if it is not already listed in the initial post above.

vogler added a commit that referenced this issue Feb 23, 2023
@Izanagi52
Copy link

Hello, here is my contribution:

Trying to redeem XXXXXXXXXXX on gog.com (need to be logged in)!
Response: {"code":"XXXXXXXXXXX","codeSeries":"ZUCM","expirationDate":1684598400,"codeType":"seriesCode","productsToSelect":1,"message":null,"discountAmount":null,"gifter":null,"products":[{"productId":"1353674058","title":"The Beast Inside - Amazon Prime","cover":"https://images.gog-statics.com/bfbbbd941e6ef18836ec1844c58d9317020a2495ff49c3ccb3398765f752e46e.jpg","image":"https://images.gog-statics.com/9d7844741c2e98d156d9c0b8b2b7b90e21a9c743fd962b4c00ea53b023dc221b_{formatter}.png","developers":["Illusion Ray Studio"],"storeUrl":"https://www.gog.com/en/game/the_beast_inside_amazon_prime","requiredProducts":[],"includedProducts":["1341028548"],"productType":"other","supportedOperatingSystems":["windows"],"extraInfo":[]}],"redeemPageUrl":"https://www.gog.com/redeem/XXXXXXXXXXX"}
TypeError: Cannot read properties of undefined (reading 'includes')
at file:///fgc/prime-gaming.js:176:24

@vogler
Copy link
Owner Author

vogler commented Apr 14, 2023

@Izanagi52 Thanks, undefined reason fixed. Was the game claimed afterwards?

@Izanagi52
Copy link

No it wasn't.
I have claimed it manually

@kennymc-c
Copy link

Just tried it with but got no response code at all after waiting several minutes. It just stops and doesn't continue with GOG. The key wasn't claimed on Legacy Games and had to be manually redeemed afterwards.

2023-04-27 19:32:24.451 started checking prime-gaming
Signed in as kennymc.c
Number of already claimed games (total): 14
Number of free unclaimed games (Prime Gaming): 0
Number of free unclaimed games (external stores): 1
Current free game: Looking for Aliens
External store: legacy games
Code to redeem game: xxx
URL to redeem game: https://promo.legacygames.com/looking-for-aliens-prime-deal
Trying to redeem xxx on legacy games (need to be logged in)!
Redeem on legacy games not yet tested!
Redeemed successfully? Please report problems in https://github.com/vogler/free-games-claimer/issues/5

@Izanagi52
Copy link

Same logs as above, and the script doesn't continue after that too (even after almost 30 minutes).
But for me, the key was successfully redeemed.

I closed the legacy game tabs via VNC, and the script resumed, and successfully finished without error.

vogler added a commit that referenced this issue May 17, 2023
@Izanagi52
Copy link

For Legacy Games, the game is redeemed, but the script stop and doesn't continue automatically (so notification are not send, and it doesn't continue to GOG)
And after a while, it crash with this log :
unexpected EOF

@vogler vogler closed this as completed in a90f90a Jul 13, 2023
free-games-claimer automation moved this from To do to Done Jul 13, 2023
@vogler vogler reopened this Jul 13, 2023
free-games-claimer automation moved this from Done to In progress Jul 13, 2023
@vogler
Copy link
Owner Author

vogler commented Jul 13, 2023

@Izanagi52 The timeout was due to a debugging pause, should be fixed with a90f90a (fixup: 22f6732).

@Izanagi52
Copy link

@vogler Yes, I can confirm it works perfectly now!

@Paffnsn
Copy link

Paffnsn commented Sep 8, 2023

What do I need to set instead of a "0" as a default entry to redeem for example games on the epic store?

@vogler
Copy link
Owner Author

vogler commented Sep 8, 2023

@Paffnsn There's just 0 and 1 which will try to redeem games for all external stores. For epic-games you just need to have your account linked on prime-gaming.

@kennymc-c
Copy link

I noticed that when an external (Epic) account is not linked (anymore) the script doesn't recognizing this and treats every try to claim an external game as a successful claim although the game has not been claimed.

@lostb1t
Copy link

lostb1t commented Oct 20, 2023

I noticed that when an external (Epic) account is not linked (anymore) the script doesn't recognizing this and treats every try to claim an external game as a successful claim although the game has not been claimed.

bit if the same for gog. When a redeem is unsuccesfull (gog captcha for example) then it will never retry.

@vogler
Copy link
Owner Author

vogler commented Oct 20, 2023

When a redeem is unsuccesfull (gog captcha for example) then it will never retry.

That is true, prime-gaming.js just checks for unclaimed games, and after getting the key, it's claimed on prime-gaming.
However, the notification should say that it failed and include the key and link to redeem it.

Could maybe add some option to retry keys in data/prime-gaming.json that have been claimed from prime-gaming but not successfully redeemed on the external store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request store: prime-gaming
Projects
free-games-claimer
  
In progress
Development

No branches or pull requests

7 participants