Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic-games: captcha on login: await notify #195

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

kevinmatthe
Copy link
Contributor

Adding async handle in captcha notify

Adding async handle in captcha notify
@kevinmatthe kevinmatthe changed the title Update epic-games.js Fixing epic-game captcha notify Aug 27, 2023
@kevinmatthe
Copy link
Contributor Author

With this issue #191

@kevinmatthe
Copy link
Contributor Author

@vogler I'm not familiar in front-end develop, so if there's any problem, please just directly point out~

@vogler
Copy link
Owner

vogler commented Aug 27, 2023

Did you test if that fixes #191?
Adding async/await shouldn't make a difference here since the call to notify will be on the task queue either way.
(At least in theory, here's some nice visualization: https://dev.to/lydiahallie/javascript-visualized-promises-async-await-5gke)

@kevinmatthe
Copy link
Contributor Author

kevinmatthe commented Aug 28, 2023

Did you test if that fixes #191? Adding async/await shouldn't make a difference here since the call to notify will be on the task queue either way. (At least in theory, here's some nice visualization: https://dev.to/lydiahallie/javascript-visualized-promises-async-await-5gke)

yes I tested this change and the console function before the notify function is correctly print to stdout. It seems to be correctly executing sync function but not the async notify.

@kevinmatthe kevinmatthe reopened this Aug 28, 2023
@vogler
Copy link
Owner

vogler commented Aug 28, 2023

Ok, maybe it makes some difference in how it's scheduled.

@vogler vogler changed the title Fixing epic-game captcha notify epic-games: captcha on login: await notify Aug 28, 2023
@vogler vogler added bug Something isn't working store: epic-games labels Aug 28, 2023
@vogler vogler merged commit 6bb1dca into vogler:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working store: epic-games
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants