Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prime-gaming: 'Claim now' -> 'Claim' for external/DLC #249

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

Primajin
Copy link
Contributor

The button was renamed to "Claim" instead of "Claim now" - I guess this causes / fixes #208

Claim

@Primajin
Copy link
Contributor Author

Primajin commented Dec 2, 2023

@vogler What do you think, shall we give this a try?

@biast12
Copy link

biast12 commented Dec 11, 2023

how am i able to test this pr? i got a ton of things to claim on twitch gaming so this would be really helpful and maybe also good to get some confirmation that it actually works too

@biast12
Copy link

biast12 commented Dec 15, 2023

just realised that the tool only claims the games and not the items, and i don't have any games to be claimed so i can't help, tho it would be really nice if we where able to claim the items too now that the tools is here

The button was renamed to "Claim" instead of "Claim now" this causes / fixes vogler#208
@Primajin
Copy link
Contributor Author

I think this should be good to merge, even if they call the button "Claim now" again in the future this would partly match if we only look for "Claim".

cc: @vogler

@vogler
Copy link
Owner

vogler commented Dec 21, 2023

Thanks! Haven't tested it but the changes looks fine.

@vogler
Copy link
Owner

vogler commented Dec 21, 2023

There was some issue with them not consistently using the text 'Claim'/'Claim now' for internal/external games, but I think that was fixed by extending the locators.

@vogler vogler changed the title Update prime-gaming.js prime-gaming: 'Claim now' -> 'Claim' for external/DLC Dec 21, 2023
@vogler vogler merged commit e18de7e into vogler:main Dec 21, 2023
0 of 2 checks passed
@Primajin Primajin deleted the patch-1 branch December 22, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Prime Gaming in game content claims fail
3 participants