Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] trying to fix things #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

rom1504
Copy link

@rom1504 rom1504 commented Oct 23, 2015

Some things have changed since this repo was last updated, mostly in voxeljs (and possibly mineflayer). Since dependencies are specified here with a >=, it's mostly broken.

I've tried updating things, and with these changes, I get no error in the browser and no error in the server, but instead it uses 100% of a core and displays nothing. Not sure what is wrong.

@deathcap
Copy link

deathcap commented Jan 2, 2016

With your changes, I do see something at http://localhost:13333/ (ran extract_textures.js on 1.8.9, using Safari 9.0.2 on OS X 10.11.2):

screen shot 2016-01-01 at 8 29 38 pm

@rom1504
Copy link
Author

rom1504 commented Jan 5, 2016

Ah yeah indeed I tried again and it displays something. Maybe there's been a new release of the dependencies, I think I'll try locking them down a bit.

@rom1504
Copy link
Author

rom1504 commented Jan 5, 2016

I'm getting a child process terminated due to receipt of signal null, and code 0 though.
Not sure what that means exactly (which process ?) but that doesn't sound good.

Problems:

  • can't move/look around
  • missing blocks : but that's normal, I commented out some of that

edit: ah no nevermind, the process terminating is browserify, that's normal

@rom1504
Copy link
Author

rom1504 commented Jan 9, 2016

it seems the can't move/look around is actually normal because it's following the bot things

what should be really fixed is the blockName / textureName mapping

I think that mapping should probably be in a minecraft-data. There might be a direct .json source in the client jar we could use ?

@rom1504
Copy link
Author

rom1504 commented Jan 10, 2016

@deathcap
Copy link

Block -> texture data is in resource packs or the client jar, path models/block, example models/block/crafting_table.json:

{
    "parent": "block/cube",
    "textures": {
        "particle": "blocks/crafting_table_front",
        "down": "blocks/planks_oak",
        "up": "blocks/crafting_table_top",
        "north": "blocks/crafting_table_front",
        "east": "blocks/crafting_table_side",
        "south": "blocks/crafting_table_side",
        "west": "blocks/crafting_table_front"
    }
}

@nice6599
Copy link

nice6599 commented Jun 1, 2020

Can we get these changes merged?
or convert the PR to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants