[Merged by Bors] - fix: remove integrations service (PL-901) #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trs
approved these changes
Apr 2, 2024
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
This fully removes the integrations service. The standard behavior is for a unknown node to get captured by the `NextHandler`: https://github.com/voiceflow/general-runtime/blob/4e455014623d48d788339953af62c4de2260c367/runtime/lib/Handlers/next.ts#L9-L16 However, this will cause breakage of the agent, as the integration node only has `node.success_id` or `node.fail_id`. Instead there is now just a stub handler that routes it to the fail port, or whatever port. To unblock infra, we have to remove `INTEGRATIONS_HANDLER_ENDPOINT` as a required env var. Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully removes the integrations service. The standard behavior is for a unknown node to get captured by the
NextHandler:https://github.com/voiceflow/general-runtime/blob/4e455014623d48d788339953af62c4de2260c367/runtime/lib/Handlers/next.ts#L9-L16
However, this will cause breakage of the agent, as the integration node only has
node.success_idornode.fail_id.Instead there is now just a stub handler that routes it to the fail port, or whatever port.
To unblock infra, we have to remove
INTEGRATIONS_HANDLER_ENDPOINTas a required env var.