fix: review feedback

voiceflow · May 31, 2024 · a8504f2 · a8504f2
1 parent d61989c
commit a8504f2
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 15 deletions.
diff --git a/lib/services/classification/classification.const.ts b/lib/services/classification/classification.const.ts
@@ -22,3 +22,5 @@ export const LEGACY_LLM_INTENT_CLASSIFICATION: IntentClassificationLLMSettings =
     content: DEFAULT_INTENT_CLASSIFICATION_PROMPT_WRAPPER_CODE,
   },
 };
+
+export const NLU_LIMIT = 10;
diff --git a/lib/services/classification/interfaces/nlu.interface.ts b/lib/services/classification/interfaces/nlu.interface.ts
@@ -73,16 +73,7 @@ export interface PredictRequest {
   dmRequest?: BaseRequest.IntentRequestPayload;
 }
 
-export interface PredictOptions {
-  filteredIntents?: string[];
-  filteredEntities?: string[];
-  excludeFilteredIntents?: boolean;
-  excludeFilteredEntities?: boolean;
-  // Legacy options for NLC
-  hasChannelIntents?: boolean;
-  locale: VoiceflowConstants.Locale;
-  platform: VoiceflowConstants.PlatformType;
-}
+export type PredictOptions = NLUPredictOptions & NLCPredictOptions;
 
 export interface NLUPredictOptions {
   filteredIntents?: string[];
@@ -91,3 +82,10 @@ export interface NLUPredictOptions {
   excludeFilteredEntities?: boolean;
   limit?: number;
 }
+
+/** @deprecated */
+export interface NLCPredictOptions {
+  hasChannelIntents?: boolean;
+  locale: VoiceflowConstants.Locale;
+  platform: VoiceflowConstants.PlatformType;
+}
diff --git a/lib/services/classification/predictor.class.ts b/lib/services/classification/predictor.class.ts
@@ -11,6 +11,7 @@ import logger from '@/logger';
 
 import { handleNLCCommand } from '../nlu/nlc';
 import { mapChannelIntent } from '../nlu/utils';
+import { NLU_LIMIT } from './classification.const';
 import { isIntentClassificationLLMSettings, isIntentClassificationNLUSettings } from './classification.utils';
 import {
   ClassificationResult,
@@ -127,19 +128,19 @@ export class Predictor extends EventEmitter {
     return response;
   }
 
-  private async nluGatewayPrediction(utterance: string, options: Partial<NLUPredictOptions>) {
+  private async nluGatewayPrediction(utterance: string, options: NLUPredictOptions) {
     const { limit, excludeFilteredEntities, excludeFilteredIntents, filteredEntities, filteredIntents } = options;
 
     const { data: prediction } = await this.config.axios
       .post<NLUIntentPrediction | null>(`${this.nluGatewayURL}/v1/predict/${this.props.versionID}`, {
         utterance,
         tag: this.props.tag,
         workspaceID: this.props.workspaceID,
+        limit: limit ?? NLU_LIMIT,
         ...(excludeFilteredEntities ? { excludeFilteredEntities } : {}),
         ...(excludeFilteredIntents ? { excludeFilteredIntents } : {}),
         ...(filteredEntities ? { filteredEntities } : {}),
         ...(filteredIntents ? { filteredIntents } : {}),
-        ...(limit ? { limit } : {}),
       })
       .catch((err: Error) => {
         logger.error(err, 'Something went wrong with NLU prediction');
@@ -148,7 +149,7 @@ export class Predictor extends EventEmitter {
     return prediction;
   }
 
-  public async nlu(utterance: string, options: Partial<NLUPredictOptions>): Promise<NLUIntentPrediction | null> {
+  public async nlu(utterance: string, options: NLUPredictOptions): Promise<NLUIntentPrediction | null> {
     const prediction = await this.nluGatewayPrediction(utterance, options);
     if (!prediction) {
       this.predictions.nlu = {
@@ -296,7 +297,7 @@ export class Predictor extends EventEmitter {
       return nlcPrediction;
     }
 
-    const nluPrediction = this.props.isTrained && (await this.nlu(utterance, { limit: 10 }));
+    const nluPrediction = this.props.isTrained && (await this.nlu(utterance, this.options));
 
     if (!nluPrediction) {
       if (isIntentClassificationLLMSettings(this.settings)) {
@@ -357,7 +358,11 @@ export class Predictor extends EventEmitter {
   }
 
   public hasErrors() {
-    return this.predictions.nlc?.error || this.predictions.nlu?.error || this.predictions.llm?.error;
+    return (
+      (this.predictions.nlc && 'error' in this.predictions.nlc) ||
+      (this.predictions.nlu && 'error' in this.predictions.nlu) ||
+      (this.predictions.llm && 'error' in this.predictions.llm)
+    );
   }
 
   public get classificationType() {