[Merged by Bors] - fix: correct shutdown sequence for http server (ENG-87) #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhihil
approved these changes
Jun 14, 2024
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Please read the full report [here](https://www.notion.so/voiceflow/general-runtime-MongoDB-issues-5dcc5295b80a4a39916b6b4a6691cf91). Put simply, we were seeing this Mongo Error: `'MongoNotConnectedError: Client must be connected before running operations` However, it was always occurring AFTER a `SIGTERM` event:  This is because we were kill all client connections first (Mongo, Redis, etc), THEN we were stopping the server from accepting new connections. What this means is that it was possible for a existing request to be executed, the mongo client to get closed, then for that request to try and make a call to mongo. To reproduce the error locally, just checkout this commit/branch: 18f076c mesh the service and try to make a API call that uses mongo to it within 30 seconds. <img width="1406" alt="Screenshot 2024-06-14 at 7 12 03 PM" src="https://github.com/voiceflow/general-runtime/assets/5643574/9f9ba100-5fc9-4647-89cc-a237ac861529"> Co-authored-by: Tyler <tylerhan97@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the full report here.
Put simply, we were seeing this Mongo Error:
'MongoNotConnectedError: Client must be connected before running operationsHowever, it was always occurring AFTER a
SIGTERMevent:This is because we were kill all client connections first (Mongo, Redis, etc), THEN we were stopping the server from accepting new connections.
What this means is that it was possible for a existing request to be executed, the mongo client to get closed, then for that request to try and make a call to mongo.
To reproduce the error locally, just checkout this commit/branch:
18f076c
mesh the service and try to make a API call that uses mongo to it within 30 seconds.