Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: correct shutdown sequence for http server (ENG-87) #847

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: correct shutdown sequence for http server (ENG-87) #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,16 @@ class Server {

/**
* Stop server
* - Stops services first, then server
* - stops accepting new connections, wait for all existing ones to drain, then stop services
*/
async stop() {
// Stop services
await this.serviceManager.stop();

if (this.server) {
this.server.close();
await once(this.server, 'close');
}

// Stop services
await this.serviceManager.stop();
}
}

Expand Down
Loading