feat: remove file size limits (PL-511) #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahsnider
changed the title
pmvrmc
approved these changes
Apr 18, 2023
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
May 2, 2023
**Fixes or implements PL-511** ### Brief description. What is this change? remove file size limits from middleware. they are being moved to the infrastructure level ### Checklist - [ ] changes have been validated in an ephemeral environment - [ ] this is a breaking change and should publish a new major version - [ ] appropriate tests have been written - [ ] any new env vars have been added to the [notion doc](https://www.notion.so/voiceflow/Add-Environment-Variables-be1b0136479f45f1adece7995a7adbfb) and infra has been notified
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"SonarCloud Code Analysis\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
jonahsnider
force-pushed
the
jonah/remove-size-limits/PL-511
branch
from
f953c5c
to
d04c1ee
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
May 9, 2023
**Fixes or implements PL-511** ### Brief description. What is this change? remove file size limits from middleware. they are being moved to the infrastructure level ### Checklist - [ ] changes have been validated in an ephemeral environment - [ ] this is a breaking change and should publish a new major version - [ ] appropriate tests have been written - [ ] any new env vars have been added to the [notion doc](https://www.notion.so/voiceflow/Add-Environment-Variables-be1b0136479f45f1adece7995a7adbfb) and infra has been notified
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"SonarCloud Code Analysis\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements PL-511
Brief description. What is this change?
remove file size limits from middleware. they are being moved to the infrastructure level
Checklist