[Merged by Bors] - fix: minor prompt optimizations (LLM-001) #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecathectZero
commented
May 15, 2023
Comment on lines
56
to
59
| const output = response.output?.trim().toUpperCase(); | ||
|
|
||
| if (output?.includes('UNKNOWN') || output?.startsWith("I'M SORRY,") || output?.includes('AS AN AI')) | ||
| return { ...response, output: null }; |
There was a problem hiding this comment.
"unknown" may still be present in a valid response:
Q: Who is D.B. Cooper?
A: D.B. was an unknown man who stole money from a plane.
There was a problem hiding this comment.
okay we can swap it back to NOT_FOUND, the main thing is it that it needs to sound somewhat natural to the model for better results
DecathectZero
commented
May 15, 2023
|
|
||
| const options = { model, system: systemWithTime, temperature, maxTokens }; | ||
|
|
||
| const context = data.chunks.map(({ originalText }) => originalText).join('\n'); |
Diophontine
approved these changes
May 15, 2023
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
May 15, 2023
Mono-chunking:
we now combine all the fetched chunks into one single blob of text.
`context: ${chunk1}\n${chunk2}`....
This has the added benefit of:
less tokens (just barely)
less reference, ("based on document 1, ....", "based on the provided references, ....")
Time Stamp injection:
https://www.notion.so/voiceflow/v3-KB-Optimization-Prompts-24a947d158fc43af8adeead21a6211c0?pvs=4#ffed22a3847c43b59e9e4f532ea05645
We now provide it with the time
AI Restrictions:
https://www.notion.so/voiceflow/v3-KB-Optimization-Prompts-24a947d158fc43af8adeead21a6211c0?pvs=4#eb1166b77cab443fb494c49b837598c5
GPT-3 is more liberal and can answer more things.
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono-chunking:
we now combine all the fetched chunks into one single blob of text.
context: ${chunk1}\n${chunk2}....This has the added benefit of:
less tokens (just barely)
less reference, ("based on document 1, ....", "based on the provided references, ....")
Time Stamp injection:
https://www.notion.so/voiceflow/v3-KB-Optimization-Prompts-24a947d158fc43af8adeead21a6211c0?pvs=4#ffed22a3847c43b59e9e4f532ea05645
We now provide it with the time
AI Restrictions:
https://www.notion.so/voiceflow/v3-KB-Optimization-Prompts-24a947d158fc43af8adeead21a6211c0?pvs=4#eb1166b77cab443fb494c49b837598c5
GPT-3 is more liberal and can answer more things.