feat: add builtin vf-memory variable (CT-000) #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4o4z
commented
Feb 21, 2024
lib/services/aiAssist.ts
Outdated
| } | ||
|
|
||
| static stringifyTranscript(messages: BaseUtils.ai.Message[]) { | ||
| return messages.map(({ role, content }) => `${role}: ${content.replaceAll('\n', ' ')}`).join('\n'); |
There was a problem hiding this comment.
replacing new lines with spaces to make the format easier to understand for AI
Suggested change
| return messages.map(({ role, content }) => `${role}: ${content.replaceAll('\n', ' ')}`).join('\n'); | |
| return messages.map(({ role, content }) => `${role}: ${content.replaceAll('\n', ' ')}`).join('\n'); |
There was a problem hiding this comment.
the newline is actually okay, Denys did some testing
Comment on lines
+27
to
+29
| if (isPathRequest(request)) { | ||
| return request.payload.label ?? null; | ||
| } |
There was a problem hiding this comment.
use button's label as user message
|
DecathectZero
approved these changes
Feb 21, 2024
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements VF-XXX** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
|
Build failed: |
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements VF-XXX** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
|
🎉 This PR is included in version 1.212.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Build failed: |
bors-vf bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Caused by: #698 The `isPathRequest` guard did not assert a payload label existed, so when using that in the ai memory variable the types indicate that payload will be there.  So accessing `payload.label` resulted in a "Cannot read payload from undefined" error. This change adds a `payload.label` check to guard itself, as the typing for `payload` is wrong, and could be null or undefined.  See: #690 Co-authored-by: Tyler Stewart <git@tylerstewart.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements VF-XXX
Brief description. What is this change?
Implementation details. How do you make this change?
Setup information
Deployment Notes
Related PRs
Checklist