[Merged by Bors] - fix: remove required-from-url (PL-754) #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theProf
approved these changes
Mar 23, 2024
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
This will never work:
`await jail.set('requireFromUrl', (url: string) => requireFromUrl(url));`
It will simply crash whenever, you can not clone anything that is not a primative object between the runtime and the v8 isolate.
I think it is better to get into the motion of deprecating this.
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Build failed: |
|
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
This will never work:
`await jail.set('requireFromUrl', (url: string) => requireFromUrl(url));`
It will simply crash whenever, you can not clone anything that is not a primative object between the runtime and the v8 isolate.
I think it is better to get into the motion of deprecating this.
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will never work:
await jail.set('requireFromUrl', (url: string) => requireFromUrl(url));It will simply crash whenever, you can not clone anything that is not a primative object between the runtime and the v8 isolate.
I think it is better to get into the motion of deprecating this.