fix: enable custom cloud url (CT-1052) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecathectZero
commented
Oct 3, 2022
| @@ -40,7 +39,8 @@ interface CarouselTrace { | |||
| cards: CardTrace[]; | |||
| } | |||
|
|
|||
| export interface RuntimeOptions extends SetOptional<VoiceflowRuntimeOptions<RuntimeContext>, 'url'> { | |||
| export interface RuntimeOptions extends Omit<VoiceflowRuntimeOptions<RuntimeContext>, 'url'> { | |||
There was a problem hiding this comment.
it's very strongly typed so SetOptional was just url?: string which is not equivalent to url?: string | undefined
effervescentia
approved these changes
Oct 3, 2022
DecathectZero
changed the base branch from
tyler/use-public-endpoint/CT-1046
to
master
DecathectZero
force-pushed
the
tyler/private-cloud-endpoint/CT-1052
branch
from
7bef5d4
to
78a7bce
Compare
|
🎉 This PR is included in version 1.23.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CT-1052
Brief description. What is this change?
pipe a
urlproperty all the way touseRuntime