fix: change default f0 method from crepe to dio #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/so_vits_svc_fork/utils.py
Outdated
| **kwargs, | ||
| ): | ||
| with timer() as t: | ||
| wav_numpy = wav_numpy.astype(np.float32) | ||
| wav_numpy /= np.quantile(np.abs(wav_numpy), 0.999) | ||
| if method in ["dio", "harvest"]: | ||
| f0 = compute_f0_pyworld(wav_numpy, p_len, sampling_rate, hop_length, method) | ||
| elif method == "crepe": | ||
| elif method == "dio": |
There was a problem hiding this comment.
This seems like a typo, no?
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 16.80% 16.80%
=======================================
Files 28 28
Lines 3391 3391
Branches 393 393
=======================================
Hits 570 570
Misses 2810 2810
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BREAKING CHANGE: all default values for f0 method changed
34j
force-pushed
the
fix/change-default-f0-method
branch
from
b2819b5
to
24353e6
Compare
|
I think we should leave the defaults for inference as they were after all since not many files are processed. |
|
I changed my mind, all the defaults will be dio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
BREAKING CHANGE: all default values for f0 method changed