Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(train): suppress pytorch logs for deprecated TypedStorage #336

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

Lordmau5
Copy link
Collaborator

As per this issue in the pytorch repository:
pytorch/pytorch#97207

It seems a fix was already included which makes it only log once for the session, instead of every time it's being accessed.

Since this is out of our control as we aren't using any .storage (or specifically TypedStorage) methods directly I feel it's okay to suppress those warnings.

Closes #330

@codecov-commenter
Copy link

Codecov Report

Merging #336 (27895d9) into main (a685123) will increase coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   20.34%   20.38%   +0.04%     
==========================================
  Files          38       38              
  Lines        3294     3296       +2     
  Branches      430      430              
==========================================
+ Hits          670      672       +2     
  Misses       2607     2607              
  Partials       17       17              
Impacted Files Coverage Δ
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)
src/so_vits_svc_fork/logger.py 82.60% <100.00%> (+1.65%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j 34j merged commit e67ac62 into voicepaw:main Apr 15, 2023
@Lordmau5 Lordmau5 deleted the fix/filter_typedstorage_logs branch April 15, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypedStorage is deprecated" while Training
3 participants