Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of post install scripts on cross builds #111

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fix execution of post install scripts on cross builds #111

merged 1 commit into from
Feb 20, 2020

Conversation

renatoaguiar
Copy link
Contributor

@renatoaguiar renatoaguiar commented Feb 18, 2020

Call register_binfmt before installing packages on mkrootfs.

@renatoaguiar renatoaguiar mentioned this pull request Feb 18, 2020
13 tasks
@the-maldridge
Copy link
Member

What is the level of portability for the 'F' flag? Currently you can with some effort run mklive on another distro's kernels and it will work.

@renatoaguiar
Copy link
Contributor Author

What is the level of portability for the 'F' flag? Currently you can with some effort run mklive on another distro's kernels and it will work.

Very high. The binfmt_misc implementation supports this flag in any recent kernel version. I checked longterm versions and it is already available in 4.9. The only longterm kernels not supporting it are 4.4 and 3.16.

@renatoaguiar
Copy link
Contributor Author

I'm curious, why the previous code didn't work? (it worked years ago when I implemented it).

I don't know, It's been failing for me for a while and that was an easy way I found to fix it. I didn't spend time investigating further, but I agreed that the original implementation should be working too.

Add missing call to register_binfmt before installing packages on
mkrootfs.
@renatoaguiar
Copy link
Contributor Author

@xtraeme It turns out it can be fixed by just adding the missing call to register_binfmt on mkrootfs (second item on the commit message). I updated the PR including that part alone and I'll push a new one with the fix binary enhancement, so we can decide later when to merge it.

@xtraeme xtraeme merged commit a7a20d5 into void-linux:master Feb 20, 2020
@renatoaguiar renatoaguiar deleted the fix-cross-building branch February 21, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants