Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vsed performance? #11238

Closed
Anachron opened this issue Apr 21, 2019 · 3 comments
Closed

Improve vsed performance? #11238

Anachron opened this issue Apr 21, 2019 · 3 comments

Comments

@Anachron
Copy link
Contributor

The commit 673504e introduces vsed and a way how to recognize non-working or not-working-anymore issues with seds.

The way this is currently handled is that for each and every sed there will be one call to sha256sum before and after each regex on each file.

Since the vsed script does not error out on issues I suggest to once call sha256sum for all files before and after each regex and then use the diff of those to generate files not modified. Not sure how much faster this is but I believe it could be quite a bit depending on how excessive vsed is used.

@maxice8
Copy link
Contributor

maxice8 commented Apr 21, 2019

That is by design to know exactly which regex stops working at whatever file.

@Anachron
Copy link
Contributor Author

Anachron commented Apr 21, 2019

You will still have this information when you check all files before and after each regex. You just diff it at another time for all files.

Edit: You use sha256sum between line 29/30 and then use it again line 43 and diff after.

sgn added a commit to sgn/void-packages that referenced this issue May 12, 2019
For a vsed call to `nf' files and `nr' regex,
the old code will make `2 * nf * nr' digest calls.
the new code will make `nf * (nr + 1)' digest calls.

[skip ci]
Refereance: void-linux#11238
sgn added a commit to sgn/void-packages that referenced this issue May 12, 2019
For a vsed call to `nf' files and `nr' regex,
the old code will make `2 * nf * nr' digest calls.
the new code will make `nf * (nr + 1)' digest calls.

Refereance: void-linux#11238
Gottox pushed a commit that referenced this issue May 14, 2019
For a vsed call to `nf' files and `nr' regex,
the old code will make `2 * nf * nr' digest calls.
the new code will make `nf * (nr + 1)' digest calls.

Refereance: #11238
atweiden pushed a commit to atweiden/voidpkgs that referenced this issue May 14, 2019
For a vsed call to `nf' files and `nr' regex,
the old code will make `2 * nf * nr' digest calls.
the new code will make `nf * (nr + 1)' digest calls.

Refereance: void-linux/void-packages#11238

void-linux/void-packages@bbce69f
DirectorX pushed a commit to DirectorX/void-packages that referenced this issue May 17, 2019
For a vsed call to `nf' files and `nr' regex,
the old code will make `2 * nf * nr' digest calls.
the new code will make `nf * (nr + 1)' digest calls.

Refereance: void-linux#11238
@Anachron
Copy link
Contributor Author

Should be solved by bbce69f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants