Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inetutils-whois simply just doesn't work #18445

Closed
shahab-vahedi opened this issue Jan 21, 2020 · 1 comment
Closed

inetutils-whois simply just doesn't work #18445

shahab-vahedi opened this issue Jan 21, 2020 · 1 comment

Comments

@shahab-vahedi
Copy link
Contributor

System

  • xuname:
    Void 5.4.12_1 x86_64 GenuineIntel notuptodate rFF

  • package:
    inetutils-whois-1.9.4_10
    iana-etc-20190504_1

Expected behavior

> whois 4.2.2.4
...
NetRange:       4.0.0.0 - 4.127.255.255
CIDR:           4.0.0.0/9
...

Actual behavior

> whois 4.2.2.4
getaddrinfo: Servname not supported for ai_socktype

Steps to reproduce the behavior

Have inetutils-whois and iana-etc installed just the way they are, and you will bump into the error message shown in Actual behavior.

How I fixed it for myself

By adding the following lines into my /etc/services:

whois              43/tcp
whois              43/udp

Note

I am not sure in which package this fix should end up, inetutils-whois or iana-etc. I think latter is the case. I wanted to submit a patch but then I noticed that iana-etc uses an update.sh to fetch its protocols and services. Is it OK if I change update.sh to add those lines to services if they are not there?
@leahneukirchen
Copy link
Member

I'd prefer to patch inetutils to use nicname to find this service. (But it's annoying legacy aliases don't show up in the official IANA assignments.)

@shahab-vahedi shahab-vahedi mentioned this issue Jan 23, 2020
Merged
atweiden pushed a commit to atweiden/voidpkgs that referenced this issue Jan 25, 2020
inetutils: fix the missing port number for whois
63ad5dd 
Fixes issue 18445:
void-linux/void-packages#18445

inetutils-whois consults the /etc/services provided by IANA to
determine the port number for the "whois" service. However, the
"whois" service is not listed in that file and when you run whois
you will end up with the following error:

> whois 4.2.2.4
  getaddrinfo: Servname not supported for ai_socktype

This patch makes use of "nicname" port which is the same number
(43) as a "whois" port and is listed in /etc/services.
Moreover, changing the whois/whois.c leads to invocation of
help2man. This is unnecessary, because no option has changed and
launching help2man during the cross compilation fails.

This fix wouldn't be possible without the help of great folks
at #voidlinux.

void-linux/void-packages@3e85421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leahneukirchen @shahab-vahedi