Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built successfully but can't install with build_style=gnu-makefile #28376

Closed
g4s8 opened this issue Feb 1, 2021 · 4 comments
Closed

Built successfully but can't install with build_style=gnu-makefile #28376

g4s8 opened this issue Feb 1, 2021 · 4 comments

Comments

@g4s8
Copy link
Contributor

g4s8 commented Feb 1, 2021

System

  • xuname:
    Void 5.10.8_1 x86_64 GenuineIntel uptodate rF
  • package:
    trying to add new package

Expected behavior

Package installed successfully

Actual behavior

=> ERROR: hashcash-1.22_1: PKGDESTDIR is empty and build_style != meta
=> ERROR: hashcash-1.22_1: cannot continue with installation!

Steps to reproduce the behavior

Hi, I'm trying to create new void package hashcash tool http://www.hashcash.org/. I created new template using xnew hashcash, and then filled required fields, the template file is:

# Template file for 'hashcash'
pkgname=hashcash
version=1.22
revision=1
build_style=gnu-makefile
make_build_args+=" hashcash docs"
make_install_args+=" hashcash" # also tried empty line
hostmakedepends="make"
makedepends=""
depends=""
short_desc="Hashcash is a proof-of-work algorithm, which has been used as a denial-of-service counter measure technique in a number of systems"
maintainer="Kirill Che. <g4s8.public@gmail.com>"
license="GPL-3.0-or-later"
homepage="http://www.hashcash.org"
distfiles="http://www.hashcash.org/source/hashcash-1.22.tgz"
checksum=0192f12d41ce4848e60384398c5ff83579b55710601c7bffe6c88bc56b547896

Then I run ./xbps-src pkg hashcash:

=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> hashcash-1.22_1: removing autodeps, please wait...
=> hashcash-1.22_1: building [gnu-makefile] for x86_64...
   [host] make-4.3_3: found (https://alpha.de.repo.voidlinux.org/current)
=> hashcash-1.22_1: installing host dependencies: make-4.3_3 ...
=> hashcash-1.22_1: running do-fetch hook: 00-distfiles ...
=> hashcash-1.22_1: running do-extract hook: 00-distfiles ...
=> hashcash-1.22_1: extracting distfile(s), please wait...
=> hashcash-1.22_1: running do-patch hook: 00-patches ...
=> hashcash-1.22_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> hashcash-1.22_1: running pre-configure hook: 01-override-config ...
=> hashcash-1.22_1: running pre-configure hook: 02-script-wrapper ...
=> hashcash-1.22_1: running pre-build hook: 02-script-wrapper ...
=> hashcash-1.22_1: running do_build ...
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe         -c -o hashcash.o hashcash.c
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe         -c -o getopt.o getopt.c
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe         -c -o libhc.o libhc.c

... skipping some build logs ...

cc hashcash.o getopt.o libhashcash.a -o hashcash -Wl,-z,relro -Wl,-z,now -Wl,--as-needed    
make: Nothing to be done for 'docs'.
=> hashcash-1.22_1: skipping check (XBPS_CHECK_PKGS is disabled) ...
=> hashcash-1.22_1: running pre-install hook: 00-libdir ...
=> hashcash-1.22_1: running pre-install hook: 02-script-wrapper ...
=> hashcash-1.22_1: running pre-install hook: 98-fixup-gir-path ...
=> hashcash-1.22_1: running do_install ...
make: 'hashcash' is up to date.
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe         -c -o sha1.o sha1.c
cc sha1.o libsha1.o -o sha1 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed    
install -d /usr/bin
install hashcash sha1 /usr/bin
install -d /usr/share/man/man1
install -m 644 hashcash.1 sha1-hashcash.1 /usr/share/man/man1
install -d /usr/share/doc/hashcash-1.22
install -m 644 README LICENSE CHANGELOG /usr/share/doc/hashcash-1.22
=> hashcash-1.22_1: running post-install hook: 00-compress-info-files ...
=> hashcash-1.22_1: running post-install hook: 00-fixup-gir-path ...
=> hashcash-1.22_1: running post-install hook: 00-libdir ...
=> hashcash-1.22_1: running post-install hook: 00-uncompress-manpages ...
=> hashcash-1.22_1: running post-install hook: 01-remove-misc ...
=> hashcash-1.22_1: running post-install hook: 02-remove-libtool-archives ...
=> hashcash-1.22_1: running post-install hook: 02-remove-perl-files ...
=> hashcash-1.22_1: running post-install hook: 02-remove-python-bytecode-files ...
=> hashcash-1.22_1: running post-install hook: 03-remove-empty-dirs ...
=> WARNING: hashcash-1.22_1: removed empty dir: /usr/lib
=> WARNING: hashcash-1.22_1: removed empty dir: /usr
=> hashcash-1.22_1: running post-install hook: 04-create-xbps-metadata-scripts ...
=> hashcash-1.22_1: running post-install hook: 05-generate-gitrevs ...
=> hashcash-1.22_1: running post-install hook: 06-strip-and-debug-pkgs ...
=> hashcash-1.22_1: running post-install hook: 10-pkglint-devel-paths ...
=> hashcash-1.22_1: running post-install hook: 11-pkglint-elf-in-usrshare ...
=> hashcash-1.22_1: running post-install hook: 12-rename-python3-c-bindings ...
=> hashcash-1.22_1: running post-install hook: 13-pkg-config-clean-xbps-cross-base-ref ...
=> hashcash-1.22_1: running post-install hook: 99-pkglint-warn-cross-cruft ...
=> hashcash-1.22_1: running pre-pkg hook: 03-rewrite-python-shebang ...
=> hashcash-1.22_1: running pre-pkg hook: 04-generate-runtime-deps ...
=> hashcash-1.22_1: running pre-pkg hook: 05-prepare-32bit ...
=> hashcash-1.22_1: running pre-pkg hook: 06-shlib-provides ...
=> hashcash-1.22_1: running pre-pkg hook: 90-set-timestamps ...
=> hashcash-1.22_1: setting mtimes to Mon Feb  1 09:14:39 AM UTC 2021
=> hashcash-1.22_1: running pre-pkg hook: 99-pkglint-subpkgs ...
=> hashcash-1.22_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: hashcash-1.22_1: PKGDESTDIR is empty and build_style != meta
=> ERROR: hashcash-1.22_1: cannot continue with installation!

It successfully built the binaries, but failed to install it. What could be a problem? The error message is not really informative and I can't find any ticket or documentation about it.

@Gottox
Copy link
Member

Gottox commented Feb 1, 2021

The package gets installed into the root instead of DESTDIR. The upstream Makefile is wrong here.

@Gottox Gottox closed this as completed Feb 1, 2021
@g4s8
Copy link
Contributor Author

g4s8 commented Feb 1, 2021

Thanks. This issue was fixed in next version of upstream package.

@notthewave
Copy link
Contributor

notthewave commented Jul 24, 2021

How can I tell that it gets installed into root instead of DESTDIR?
Have the same error output trying to package nwg-dock.

@paper42
Copy link
Member

paper42 commented Jul 24, 2021

@notthewave xbps-src should tell you that the resulting package is empty:

=> ERROR: hashcash-1.22_1: PKGDESTDIR is empty and build_style != meta
=> ERROR: hashcash-1.22_1: cannot continue with installation!

Also, you should always try installing the package before you submit it, so you would notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants