Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel-gmmlib package requires more CPU features than Void baselineand is compiled with -march=corei7 #29801

Closed
ericonr opened this issue Mar 28, 2021 · 2 comments · Fixed by #30074
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ericonr
Copy link
Member

ericonr commented Mar 28, 2021

Reported by @sgn on IRC.

Per https://github.com/intel/gmmlib/blob/2072b0d1e8ba2cba2f94bc2c1fda89d6e457a50b/Source/GmmLib/Linux.cmake :

    # General optimization options
    -march=${GMMLIB_MARCH}
    -mpopcnt
    -msse
    -msse2
    -msse3
    -mssse3
    -msse4
    -msse4.1
    -msse4.2
    -mfpmath=sse
    -finline-functions
    -fno-short-enums
    -Wa,--noexecstack
    -fno-strict-aliasing
    # Common defines
    -DUSE_MMX
    -DUSE_SSE
    -DUSE_SSE2
    -DUSE_SSE3
    -DUSE_SSSE3

GMMLIB_MARCH is set to corei7 by default, but we can fix that with configure_args. What I also worry about are all the -msse* switches, since afaik they can affect generated code that isn't directly using compiler intrinsics for them.

@ericonr ericonr added bug Something isn't working help wanted Extra attention is needed labels Mar 28, 2021
@tornaria
Copy link
Contributor

tornaria commented Apr 6, 2021

It seems, according to https://github.com/intel/gmmlib#supported-platforms, that the supported graphic devices already imply the cpu supports all that.

@ericonr
Copy link
Member Author

ericonr commented Apr 6, 2021

It seems corei7 is mostly equivalent to nehalem:

  {"corei7", PROCESSOR_NEHALEM, CPU_NEHALEM, PTA_NEHALEM},

I don't know if it makes sense to force a different target, then - corei7 probably generates slightly better code here than x86_64 would. Maybe we it might just be enough to document these constraints in the template itself. Thanks for the hint!

ericonr added a commit to ericonr/void-packages that referenced this issue Apr 7, 2021
Reported by sgn
Suggestion for "fix" by tornaria
Closes void-linux#29801
ericonr added a commit that referenced this issue Apr 11, 2021
Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801
adbrown101 pushed a commit to adbrown101/void-packages that referenced this issue Apr 12, 2021
Reported by sgn
Suggestion for "fix" by tornaria
Closes void-linux#29801
Veganizer pushed a commit to Veganizer/void-packages that referenced this issue Apr 13, 2021
Reported by sgn
Suggestion for "fix" by tornaria
Closes void-linux#29801
hazayan pushed a commit to hazayan/void-packages that referenced this issue Apr 15, 2021
Reported by sgn
Suggestion for "fix" by tornaria
Closes void-linux#29801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants